Programmers Resource - Error - Too Few Parameters

View Full Version : Error - Too Few Parameters

ubigdummie

06-10-2003, 11:35 PM

Hey guys. I'm still learning here - I'm a newbie to ASP. I have a form (addvehicle.asp) which posts to managevehicles.asp. Managevehicles.asp inserts the record or updates the record depending on if I come from addvehicle.asp or updatevehicle.asp. I keep getting this error after I click the Add Vehicle submit button on addvehicle.asp:
-------------
Error Type:
Microsoft OLE DB Provider for ODBC Drivers (0x80040E10)
[Microsoft][ODBC Microsoft Access Driver] Too few parameters. Expected 2.
/Inventory/managevehicles.asp, line 221
-------------
Here is my code for managevehicles.asp
-------------
<%
FUNCTION fixQuotes( theString )
fixQuotes = REPLACE( theString, "'", "''" )
END FUNCTION

' Get the Form Variables
addVehicle = TRIM( Request( "addVehicle" ) )
updateVehicle = TRIM( Request( "updateVehicle" ) )

vehicleID = TRIM( Request( "vehicleID" ) )
stockNumber = TRIM( Request( "stockNumber" ) )
VIN = TRIM( Request( "VIN" ) )
make = TRIM( Request( "make" ) )
model = TRIM( Request( "model" ) )
autoYear = TRIM( Request( "autoYear" ) )
transmission = TRIM( Request( "transmission" ) )
engine = TRIM( Request( "engine" ) )
exteriorColor = TRIM( Request( "exteriorColor" ) )
interiorColor = TRIM( Request( "interiorColor" ) )
vehiclePicture = TRIM( Request( "vehiclePicture" ) )
priceRange = TRIM( Request( "priceRange" ) )
sellingPrice = TRIM( Request( "sellingPrice" ) )
mileage = TRIM( Request( "mileage" ) )
bodyStyle = TRIM( Request( "bodyStyle" ) )
numberDoors = TRIM( Request( "numberDoors" ) )
options = TRIM( Request( "options" ) )
dealershipPhone = TRIM( Request( "dealershipPhone" ) )
salesmanName = TRIM( Request( "salesmanName" ) )
salesmanExt = TRIM( Request( "salesmanExt" ) )
salesmanEmail = TRIM( Request( "salesmanEmail" ) )
vehicleStatus = TRIM( Request( "vehicleStatus" ) )
autoType = TRIM( Request( "autoType" ) )

' Assign Default Values
IF vehicleID = "" THEN
vehicleID = "?????"
END IF
IF priceRange = "" or NOT isNUMERIC( priceRange ) THEN
priceRange = 0
END IF
IF sellingPrice = "" or NOT isNUMERIC( sellingPrice ) THEN
sellingPrice = 0
END IF
IF vin = "" THEN
vin = "?????"
END IF
IF make = "" THEN
make = "?????"
END IF
IF model = "" THEN
model = "?????"
END IF
IF autoYear = "" THEN
autoYear = "?????"
END IF
IF transmission = "" THEN
transmission = "?????"
END IF
IF engine = "" THEN
engine = "?????"
END IF
IF exteriorColor = "" THEN
exteriorColor = "?????"
END IF
IF interiorColor = "" THEN
interiorColor = "?????"
END IF
IF vehiclePicture = "" THEN
vehiclePicture = "?????"
END IF
IF mileage = "" THEN
mileage = "?????"
END IF
IF bodyStyle = "" THEN
bodyStyle = "?????"
END IF
IF numberDoors = "" THEN
numberDoors = "?????"
END IF
IF options = "" THEN
options = "?????"
END IF
IF dealershipPhone = "" THEN
dealershipPhone = "?????"
END IF
IF salesmanName = "" THEN
salesmanName = "?????"
END IF
IF salesmanExt = "" THEN
salesmanExt = "?????"
END IF
IF salesmanEmail = "" THEN
salesmanEmail = "?????"
END IF
IF vehicleStatus = "" THEN
vehicleStatus = "?????"
END IF
IF autoType = "" THEN
autoType = "?????"
END IF

' Open the Database Connection
Set Con = Server.CreateObject( "ADODB.Connection" )
Con.Open "Inventory"
%>
<html>
<head><title>Manage Inventory</title></head>
<body bgcolor="darkblue">
<%
' Add New Product
IF addProduct <> "" THEN

sqlString = "INSERT INTO Preowned " &_
"( vehicle_id, stock_number, vehicle_vin, " &_
"vehicle_make, vehicle_model, auto_year, " &_
"vehicle_transmission, vehicle_engine, exterior_color, " &_
"interior_color, vehicle_picture, price_range, " &_
"selling_price, vehicle_mileage, body_style, " &_
"number_doors, vehicle_options, dealership_phone, " &_
"salesman_name, salesman_ext, salesman_email, vehicle_status, " &_
"auto_type ) VALUES ( " &_
" '" & vehicleID & "', " &_
" '" & stockNumber & "', " &_
" '" & VIN & "', " &_
" '" & make & "', " &_
" '" & model & "', " &_
" '" & autoYear & "', " &_
" '" & transmission & "', " &_
" '" & engine & "', " &_
" '" & exteriorColor & "', " &_
" '" & interiorColor & "', " &_
" '" & vehiclePicture & "', " &_
priceRange & ", " &_
sellingPrice & ", " &_
mileage & ", " &_
" '" & bodyStyle & "', " &_
numberDoors & ", " &_
" '" & options & "', " &_
" '" & dealershipPhone & "', " &_
" '" & salesmanName & "', " &_
salesmanExt & ", " &_
" '" & salesmanEmail & "', " &_
" '" & autoType & "', " &_
vehicleStatus & " )"

Con.Execute sqlString

%>
<center>
<table width="600" cellpadding="4"
cellspacing="0" bgcolor="lightyellow">
<tr>
<td> <%=VIN%> was added to the inventory.</td>
</tr>
</table>
</center>
<p>
<%
END IF

' Update Vehicle
IF updateVehicle <> "" THEN

sqlString = "UPDATE Preowned SET " &_
"stock_number='" & fixQuotes( stockNumber ) & "'," &_
"vehicle_vin='" & fixQuotes( VIN ) & "'," &_
"vehicle_make='" & fixQuotes( make ) & "'," &_
"vehicle_model='" & fixQuotes( model ) & "'," &_
"auto_year='" & fixQuotes( autoYear ) & "'," &_
"vehicle_transmission='" & fixQuotes( transmission ) & "'," &_
"vehicle_engine='" & fixQuotes( engine ) & "'," &_
"exterior_color='" & fixQuotes( exteriorColor ) & "'," &_
"interior_color='" & fixQuotes( interiorColor ) & "'," &_
"vehicle_picture='" & fixQuotes( vehiclePicture ) & "'," &_
"vehicle_mileage='" & fixQuotes( mileage ) & "'," &_
"body_style='" & fixQuotes( bodyStyle ) & "'," &_
"number_doors='" & fixQuotes( numberDoors ) & "'," &_
"vehicle_options='" & fixQuotes( options ) & "'," &_
"dealership_phone='" & fixQuotes( dealershipPhone ) & "'," &_
"price_range=" & cCUR( priceRange ) & "," &_
"selling_price=" & cCUR( sellingPrice ) & "," &_
"salesman_name='" & fixQuotes( salesmanName ) & "'," &_
"salesman_ext='" & fixQuotes( salesmanExt ) & "'," &_
"salesman_email='" & fixQuotes( salesmanEmail ) & "'," &_
"vehicle_status=" & vehicleStatus & " WHERE " &_
"vehicle_id=" & vehicleID

Con.Execute sqlString

%>
<center>
<table width="600" cellpadding="4"
cellspacing="0" bgcolor="lightyellow">
<tr>
<td> <%=VIN%> was updated in the inventory.</td>
</tr>
</table>
</center>
<p>
<%
END IF

%>

<center>
<table width="600" border=1 bgcolor="lightyellow"
cellpadding="4" cellspacing="0">
<tr>
<td colspan="2" bgcolor="yellow"> <font face="Arial" size="3"><b> Manage
Vehicles</b></font> </td>
</tr>
<tr>
<td align="center">

<table border="1" size="400" cellpadding="3"
cellspacing=0 bgcolor="white">
<%
sqlString = "SELECT stock_number, vehicle_vin FROM Preowned " &_
"ORDER BY vehicle_vin"
SET RS = Con.Execute( sqlString )
WHILE NOT RS.EOF
%>
<tr>
<td>
<a href="updateVehicle.asp?vid=<%=RS( "stock_number")%>">
<%=RS( "vehicle_vin" )%></a>
</td>
</tr>
<%
RS.MoveNext
WEND
%>
</table>
</td>
</tr>
<tr>
<td>
<a href="addVehicle.asp">Add Vehicle</a>
</td>
</tr>
</table>
</center>

</body>
</html>
-------------
If anyone can help me here, I would greatly appreciate it.
Thanks.
Andy

Angelika

06-11-2003, 10:56 AM

Try this:
<%
FUNCTION fixQuotes( theString )
fixQuotes = REPLACE( theString, "'", "''" )
END FUNCTION

' Get the Form Variables
addVehicle = TRIM( Request( "addVehicle" ) )
updateVehicle = TRIM( Request( "updateVehicle" ) )

vehicleID = TRIM( Request( "vehicleID" ) )
stockNumber = TRIM( Request( "stockNumber" ) )
VIN = TRIM( Request( "VIN" ) )
make = TRIM( Request( "make" ) )
model = TRIM( Request( "model" ) )
autoYear = TRIM( Request( "autoYear" ) )
transmission = TRIM( Request( "transmission" ) )
engine = TRIM( Request( "engine" ) )
exteriorColor = TRIM( Request( "exteriorColor" ) )
interiorColor = TRIM( Request( "interiorColor" ) )
vehiclePicture = TRIM( Request( "vehiclePicture" ) )
priceRange = TRIM( Request( "priceRange" ) )
sellingPrice = TRIM( Request( "sellingPrice" ) )
mileage = TRIM( Request( "mileage" ) )
bodyStyle = TRIM( Request( "bodyStyle" ) )
numberDoors = TRIM( Request( "numberDoors" ) )
options = TRIM( Request( "options" ) )
dealershipPhone = TRIM( Request( "dealershipPhone" ) )
salesmanName = TRIM( Request( "salesmanName" ) )
salesmanExt = TRIM( Request( "salesmanExt" ) )
salesmanEmail = TRIM( Request( "salesmanEmail" ) )
vehicleStatus = TRIM( Request( "vehicleStatus" ) )
autoType = TRIM( Request( "autoType" ) )

' Assign Default Values
IF vehicleID = "" THEN
vehicleID = "?????"
END IF
IF priceRange = "" or NOT isNUMERIC( priceRange ) THEN
priceRange = 0
END IF
IF sellingPrice = "" or NOT isNUMERIC( sellingPrice ) THEN
sellingPrice = 0
END IF
IF vin = "" THEN
vin = "?????"
END IF
IF make = "" THEN
make = "?????"
END IF
IF model = "" THEN
model = "?????"
END IF
IF autoYear = "" THEN
autoYear = "?????"
END IF
IF transmission = "" THEN
transmission = "?????"
END IF
IF engine = "" THEN
engine = "?????"
END IF
IF exteriorColor = "" THEN
exteriorColor = "?????"
END IF
IF interiorColor = "" THEN
interiorColor = "?????"
END IF
IF vehiclePicture = "" THEN
vehiclePicture = "?????"
END IF
IF mileage = "" THEN
mileage = "?????"
END IF
IF bodyStyle = "" THEN
bodyStyle = "?????"
END IF
IF numberDoors = "" THEN
numberDoors = "?????"
END IF
IF options = "" THEN
options = "?????"
END IF
IF dealershipPhone = "" THEN
dealershipPhone = "?????"
END IF
IF salesmanName = "" THEN
salesmanName = "?????"
END IF
IF salesmanExt = "" THEN
salesmanExt = "?????"
END IF
IF salesmanEmail = "" THEN
salesmanEmail = "?????"
END IF
IF vehicleStatus = "" THEN
vehicleStatus = "?????"
END IF
IF autoType = "" THEN
autoType = "?????"
END IF

' Open the Database Connection
Set Con = Server.CreateObject( "ADODB.Connection" )
Con.Open "Inventory"
set RS = server.CreateObject("adodb.recordset")
%>
<html>
<head><title>Manage Inventory</title></head>
<body bgcolor="darkblue">
<%
' Add New Product
IF addProduct <> "" THEN
rs.Open"select * from Preowned",con,3,3
RS.AddNew
RS.Fields("vehicle_id")=vehicleID
RS.Fields("stock_number") =stockNumber
RS.Fields("vehicle_vin") =VIN
RS.Fields("vehicle_make") =make
RS.Fields("vehicle_model") = model
RS.Fields("auto_year") = autoYear
RS.Fields("vehicle_transmission") = transmission
RS.Fields("vehicle_engine") = engine
RS.Fields("exterior_color") = exteriorColor
RS.Fields("interior_color") = interiorColor
RS.Fields("vehicle_picture") = vehiclePicture
RS.Fields("price_range") = priceRange
RS.Fields("selling_price") = sellingPrice
RS.Fields("vehicle_mileage") = mileage
RS.Fields("body_style") = bodyStyle
RS.Fields("number_doors") = numberDoors
RS.Fields("vehicle_options") = options
RS.Fields("dealership_phone") = dealershipPhone
RS.Fields("salesman_name") = salesmanName
RS.Fields("salesman_ext") = salesmanExt
RS.Fields("salesman_email") = salesmanEmail
RS.Fields("vehicle_status") = autoType
RS.Fields("auto_type") = vehicleStatus
RS.Update

Rs.close
%>
<center>
<table width="600" cellpadding="4"
cellspacing="0" bgcolor="lightyellow">
<tr>
<td> <%=VIN%> was added to the inventory.</td>
</tr>
</table>
</center>
<p>
<%
END IF

' Update Vehicle
IF updateVehicle <> "" THEN

sqlString= "select * from Preowned "
sqlString= sqlString + "WHERE vehicle_id= "&vehicleID&""
RS.Open sqlString ,Conn,3,3
If Not RS.EOF Then
RS.Fields("stock_number") = stockNumber
RS.Fields("vehicle_vin") = VIN
RS.Fields("vehicle_make") =make
RS.Fields("vehicle_model") = model
RS.Fields("auto_year") = autoYear
RS.Fields("vehicle_transmission") = transmission
RS.Fields("vehicle_engine") = engine
RS.Fields("exterior_color") = exteriorColor
RS.Fields("interior_color") = interiorColor
RS.Fields("vehicle_picture") = vehiclePicture
RS.Fields("price_range") = priceRange
RS.Fields("selling_price") = sellingPrice
RS.Fields("vehicle_mileage") = mileage
RS.Fields("body_style") = bodyStyle
RS.Fields("number_doors") = numberDoors
RS.Fields("vehicle_options") = options
RS.Fields("dealership_phone") = dealershipPhone
RS.Fields("salesman_name") = salesmanName
RS.Fields("salesman_ext") = salesmanExt
RS.Fields("salesman_email") = salesmanEmail
RS.Fields("vehicle_status") = autoType
RS.Fields("auto_type") = vehicleStatus
RS.Update
End If
RS.Close
%>
<center>
<table width="600" cellpadding="4"
cellspacing="0" bgcolor="lightyellow">
<tr>
<td> <%=VIN%> was updated in the inventory.</td>
</tr>
</table>
</center>
<p>
<%
END IF

%>

<center>
<table width="600" border=1 bgcolor="lightyellow"
cellpadding="4" cellspacing="0">
<tr>
<td colspan="2" bgcolor="yellow"> <font face="Arial" size="3"><b> Manage
Vehicles</b></font> </td>
</tr>
<tr>
<td align="center">

<table border="1" size="400" cellpadding="3"
cellspacing=0 bgcolor="white">
<%
sqlString = "SELECT stock_number, vehicle_vin FROM Preowned "
sqlString =sqlString + "ORDER BY vehicle_vin"
RS.Open sqlString,Con

WHILE NOT RS.EOF
%>
<tr>
<td>
<a href="updateVehicle.asp?vid=<%=RS( "stock_number")%>">
<%=RS( "vehicle_vin" )%></a>
</td>
</tr>
<%
RS.MoveNext
WEND
%>
</table>
</td>
</tr>
<tr>
<td>
<a href="addVehicle.asp">Add Vehicle</a>
</td>
</tr>
</table>
</center>

</body>
</html>

-----------------------------------------------------------
And check every field data type and lenght (Preowned table)

ubigdummie

06-14-2003, 10:18 PM

You guys are awesome. Thanks for all the help. I haven't been able to do much of anything the last couple of days because I've been moving. I've just checked my email and saw there was a reply, so I just wanted to thank you. I'll let you know if it works as soon as I can try it out.
Much thanks.
Andy